Add delete predicate for gateway class #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hckuo! Welcome to the project! 🎉 Thanks for opening this pull request! |
kate-osborn
requested changes
Mar 15, 2024
There was a problem hiding this comment.
@hckuo thanks for working on this, it looks good!
I manually verified that the delete events for GatewayClasses with a different controller name are filtered out by the predicate.
Can you update the PR description and fill out the template? Thanks!
kate-osborn
requested changes
Mar 21, 2024
…teway-fabric into hck/0314/delete-predicate
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1696 +/- ##
==========================================
+ Coverage 86.16% 86.18% +0.01%
==========================================
Files 87 87
Lines 5515 5522 +7
Branches 52 52
==========================================
+ Hits 4752 4759 +7
Misses 717 717
Partials 46 46 ☔ View full report in Codecov by Sentry. |
kate-osborn
approved these changes
Apr 2, 2024
sjberman
approved these changes
Apr 2, 2024
amimimor
pushed a commit
to amimimor/nginx-gateway-fabric
that referenced
this pull request
Apr 3, 2024
Problem: The controller reconciles delete events for GatewayClasses that are not owned by NGF. Solution: Add a delete function to the GatewayClass predicate that ignores delete events for GatewayClasses with the wrong controller name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds a delete predicate to the gateway class checking if the controller name matches the predicate name.
Problem:
Solve the issue of #1476 where reconciler should not delete the gateway resource if the name does not match.
Solution:
Add a delete predicate to the gateway class checking if the controller name matches the predicate name.
Testing:
This PR is unit-tested.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #1476
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.