Enforce that the SNI name matches the host name #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Nginx does not enforce that the SNI name matches the host name for SSL requests, which can lead to unexpected behavior and breaks the recommendation of the gateway API spec. Fix: in every SSL server block, we now check that the variables $ssl_server_name and $host are equal. If they are not, we return a 421 misdirected request.
kate-osborn
force-pushed
the
fix/sni-enforcement
branch
from
ff7cecf
to
1d20000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Nginx does not enforce that the SNI name matches the host name for SSL
requests, which can lead to unexpected behavior and breaks the
recommendation of the gateway API spec.
Fix: in every SSL server block, we now check that the variables $ssl_server_name
and $host are equal. If they are not, we return a 421 misdirected request.