Disable sending telemetry in tests #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: b6cb677 enabled product telemetry reporting. However, the telemetry is also reported when running tests, which we want to avoid, so that the gathered telemetry doesn't include data from our test runs. Solution: Disable telemetry for: - Conformance tests - Helm chart - NFR and functional tests CLOSES - #1705 Testing: - To be confirmed by the pipeline - Ran telemetry functional test manually successfully. - Ran NGR test successfully on GCP. No telemetry were reported, confirmed on the telemetry receiver side. (Note. Upgrade test failed with "Error: INSTALLATION FAILED: release name "": no name provided" error. However, this was not caused by this commit and out of scope of this commit)
kate-osborn
approved these changes
Mar 18, 2024
lucacome
approved these changes
Mar 18, 2024
sjberman
approved these changes
Mar 18, 2024
amimimor
pushed a commit
to amimimor/nginx-gateway-fabric
that referenced
this pull request
Apr 3, 2024
Problem: b6cb677 enabled product telemetry reporting. However, the telemetry is also reported when running tests, which we want to avoid, so that the gathered telemetry doesn't include data from our test runs. Solution: Disable telemetry for: - Conformance tests - Helm chart - NFR and functional tests CLOSES - nginxinc#1705 Testing: - To be confirmed by the pipeline - Ran telemetry functional test manually successfully. - Ran NGR test successfully on GCP. No telemetry were reported, confirmed on the telemetry receiver side. (Note. Upgrade test failed with "Error: INSTALLATION FAILED: release name "": no name provided" error. However, this was not caused by this commit and out of scope of this commit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
b6cb677 enabled product telemetry reporting.
However, the telemetry is also reported when running tests, which we want to avoid, so that the gathered telemetry doesn't include data from our test runs.
Solution:
Disable telemetry for:
CLOSES - #1705
Testing:
Closes #ISSUE
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.