Fix NFR upgrade test #1716
Merged
Fix NFR upgrade test #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: NFR performance test fails with the following error: Error: INSTALLATION FAILED: release name "": no name provided Solution: Fix the test by providing the release name. Also, add a missing nfr config setting. CLOSES nginxinc#1715 Testing: - Ran upgrade test successfully
sjberman
approved these changes
Mar 18, 2024
kate-osborn
approved these changes
Mar 18, 2024
amimimor
pushed a commit
to amimimor/nginx-gateway-fabric
that referenced
this pull request
Apr 3, 2024
Problem: NFR performance test fails with the following error: Error: INSTALLATION FAILED: release name "": no name provided Solution: Fix the test by providing the release name. Also, add a missing nfr config setting. CLOSES nginxinc#1715 Testing: - Ran upgrade test successfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
NFR performance test fails with the following error: Error: INSTALLATION FAILED: release name "": no name provided
Solution:
Fix the test by providing the release name.
Also, add a missing nfr config setting.
CLOSES #1715
Testing:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.