Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken Conformance badge from README #1719

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

sjberman
Copy link
Contributor

Problem: Now that the Conformance tests run as part of the CI workflow, the badge for the Conformance workflow no longer works.

Solution: Remove this badge in favor of the CI badge.

Problem: Now that the Conformance tests run as part of the CI workflow, the badge for the Conformance workflow no longer works.

Solution: Remove this badge in favor of the CI badge.
@sjberman sjberman requested a review from a team as a code owner March 19, 2024 14:43
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks labels Mar 19, 2024
@sjberman sjberman enabled auto-merge (squash) March 19, 2024 16:56
@sjberman sjberman disabled auto-merge March 19, 2024 17:09
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.93%. Comparing base (4f4fa72) to head (d4eb074).
Report is 1 commits behind head on main.

❗ Current head d4eb074 differs from pull request most recent head 9db658e. Consider uploading reports for the commit 9db658e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##              main    #1719       +/-   ##
============================================
- Coverage   100.00%   85.93%   -14.07%     
============================================
  Files            1       87       +86     
  Lines          209     5511     +5302     
  Branches        52       52               
============================================
+ Hits           209     4736     +4527     
- Misses           0      723      +723     
- Partials         0       52       +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman merged commit 2a6c450 into nginxinc:main Mar 19, 2024
38 checks passed
@sjberman sjberman deleted the chore/badge-conformance branch March 19, 2024 17:26
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this pull request Apr 3, 2024
Problem: Now that the Conformance tests run as part of the CI workflow, the badge for the Conformance workflow no longer works.

Solution: Remove this badge in favor of the CI badge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants