Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix automated NFR issues with OSS vs Plus #1721

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Fix automated NFR issues with OSS vs Plus #1721

merged 2 commits into from
Mar 19, 2024

Conversation

sjberman
Copy link
Contributor

Problem:

  • All results files used the same name
  • The PR branch was the same for both OSS and Plus
  • Plus image was not used when running tests

Solution:

  • Separate OSS and Plus runs to use correct images, write to separate files, and use a separate branch.

Testing: Ran tests with both OSS and Plus and verified images and files used the correct names.

Closes #1703

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

None

@sjberman
Fix automated NFR issues with OSS vs Plus
be7f5dc 
Problem:
- All results files used the same name
- The PR branch was the same for both OSS and Plus
- Plus image was not used when running tests

Solution:
- Separate OSS and Plus runs to use correct images, write to separate files, and use a separate branch.
@sjberman sjberman requested a review from a team as a code owner March 19, 2024 16:17
@github-actions github-actions bot added the tests Pull requests that update tests label Mar 19, 2024
@sjberman sjberman enabled auto-merge (squash) March 19, 2024 16:49
@sjberman sjberman merged commit 4f4fa72 into nginxinc:main Mar 19, 2024
40 checks passed
@sjberman sjberman deleted the tests/plus-results-nfr branch March 19, 2024 16:55
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this pull request Apr 3, 2024
@sjberman @amimimor
Fix automated NFR issues with OSS vs Plus (nginxinc#1721)
7d79551 
Problem:
- All results files used the same name
- The PR branch was the same for both OSS and Plus
- Plus image was not used when running tests

Solution:
- Separate OSS and Plus runs to use correct images, write to separate files, and use a separate branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Longevity test runner doesn't use NGINX Plus image
3 participants
@sjberman @pleshakov @kate-osborn