Do not send telemetry data if failure in collection

[bjee19]

Fix error handling in telemetry and usage reporting

Problem: We send empty telemetry data if there is any failure in collection of data. We also do the same for NIM usage reporting.

Solution: Don't send telemetry data in case of failure of collection. Also does not send data for NIM usage reporting if there was any failure. Refactored some tests to comply with code coverage.

Testing: Manually verified bug described in #1729 no longer occurs.

Closes #1729

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.16%. Comparing base (16bdfa8) to head (2cc1f28).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1731      +/-   ##
==========================================
+ Coverage   85.93%   86.16%   +0.22%     
==========================================
  Files          87       87              
  Lines        5511     5515       +4     
  Branches       52       52              
==========================================
+ Hits         4736     4752      +16     
+ Misses        723      717       -6     
+ Partials       52       46       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pleshakov]

Let's make sure the commit message and PR message adequately represent its content.

Since we're fixing two problems, we can say:

"Fix error handling in telemetry and usage reporting"

and describe both problems in the problem section.

Also, I'd recommend creating a separate issue for the problem with usage reporting. So that this commit/PR closes 2 issues.

For unexpected linting fixing, for future, better to have a separate PR -- it can be approved and merged much quicker and thus unblock other PRs and merging to main.

[bjee19]

Also, I'd recommend creating a separate issue for the problem with usage reporting. So that this commit/PR closes 2 issues.

I think it'd be fine just fixing the other issue without creating an issue as its so small and related.

For unexpected linting fixing, for future, better to have a separate PR -- it can be approved and merged much quicker and thus unblock other PRs and merging to main.

Yea this sounds better I'll make sure to do this in the future!

[pleshakov]

@bjee19 PR message is still not updated