Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Release PR workflow #1732

Merged
merged 7 commits into from
Mar 20, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Mar 20, 2024

Proposed changes

Problem: Manually updating the old tag is boring and error prone

Solution: Automate the process and automatically open a PR for the
release

Closes #1418

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested review from a team as code owners March 20, 2024 02:07
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks helm-chart Relates to helm chart labels Mar 20, 2024
.github/workflows/release-pr.yml Show resolved Hide resolved
.github/workflows/release-pr.yml Show resolved Hide resolved
.github/workflows/release-pr.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the helm-chart Relates to helm chart label Mar 20, 2024
Problem: Manually updating the old tag is boring and error prone

Solution: Automate the process and automatically open a PR for the
release
@lucacome lucacome force-pushed the chore/create-release-workflow branch from 7db169a to 1dc4010 Compare March 20, 2024 16:46
@github-actions github-actions bot added the helm-chart Relates to helm chart label Mar 20, 2024
@github-actions github-actions bot removed the helm-chart Relates to helm chart label Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.16%. Comparing base (45a4085) to head (263c23d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1732      +/-   ##
==========================================
+ Coverage   85.62%   86.16%   +0.54%     
==========================================
  Files          86       87       +1     
  Lines        5306     5515     +209     
  Branches        0       52      +52     
==========================================
+ Hits         4543     4752     +209     
  Misses        717      717              
  Partials       46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome enabled auto-merge (squash) March 20, 2024 22:01
@lucacome lucacome merged commit 17c007b into nginxinc:main Mar 20, 2024
40 checks passed
@lucacome lucacome deleted the chore/create-release-workflow branch March 20, 2024 22:17
salonichf5 pushed a commit to salonichf5/nginx-gateway-fabric that referenced this pull request Mar 20, 2024
Problem: Manually updating the old tag is boring and error prone

Solution: Automate the process and automatically open a PR for the
release
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this pull request Apr 3, 2024
Problem: Manually updating the old tag is boring and error prone

Solution: Automate the process and automatically open a PR for the
release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update old tags on release
5 participants