Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test results for zero downtime scaling #1733

Merged
merged 11 commits into from
Mar 20, 2024
Merged

Add test results for zero downtime scaling #1733

merged 11 commits into from
Mar 20, 2024

Conversation

salonichf5
Copy link
Contributor

@salonichf5 salonichf5 commented Mar 20, 2024 •
edited

Proposed changes

Testing: Add test results for zero downtime scaling

Closes #1648

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 20, 2024
@salonichf5 salonichf5 force-pushed the downtime-scaling branch 2 times, most recently from 53253f0 to c8ab8ec Compare March 20, 2024 17:14
@salonichf5 salonichf5 marked this pull request as ready for review March 20, 2024 17:21
@salonichf5 salonichf5 requested a review from a team as a code owner March 20, 2024 17:21
@sjberman sjberman changed the title Add test results for zero downtime scaling with 10 nodes Add test results for zero downtime scaling Mar 20, 2024
@sjberman
Copy link
Contributor

Be sure when you create branches you add the proper prefix to ensure labels are added to the PR properly. For example, this branch name should start with tests/downtime-scaling.

@sjberman sjberman added the tests Pull requests that update tests label Mar 20, 2024
sjberman
sjberman reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks good, other than just needing a summary at the top.

The graph for 10 node does look different with those points, not sure why.

@github-actions github-actions bot removed the tests Pull requests that update tests label Mar 20, 2024
@salonichf5
Copy link
Contributor Author

I re-did the test for 10 node, gradual scaling up which did not have correct results. It was my first test so maybe i missed a step or two before generating the graph or did something iffy.

I re-did the test and have uploaded new results @sjberman @pleshakov @bjee19 . Please take a look and let me know

@salonichf5 salonichf5 requested a review from a team as a code owner March 20, 2024 22:20
@salonichf5 salonichf5 merged commit e9df8b8 into nginxinc:main Mar 20, 2024
40 checks passed
@salonichf5 salonichf5 added tests Pull requests that update tests and removed documentation Improvements or additions to documentation labels Mar 21, 2024
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this pull request Apr 3, 2024
@salonichf5 @amimimor
Add test results for zero downtime scaling (nginxinc#1733)
4321305 
Adds tests results for zero downtime scaling for 1.2.0 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@sjberman sjberman sjberman approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

@bjee19 bjee19 bjee19 approved these changes

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.2 Zero Downtime Scaling Test
5 participants
@salonichf5 @sjberman @pleshakov @kate-osborn @bjee19