Gateway Settings Enhancement Proposal

[sjberman]

Problem: We want a design for GatewayClass level settings that applies to all Gateways, such as otel_exporter.

Solution: Add enhancement proposal introducing the NginxProxy CRD, which will contain the Gateway settings.

Enhancement Proposal: #1775

Closes #1660

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

[sjberman]

@pleshakov @kate-osborn Due to issues with singular/plural resource names, should this be renamed to GatewayConfig and GatewayConfigs?

[kate-osborn]

@pleshakov @kate-osborn Due to issues with singular/plural resource names, should this be renamed to GatewayConfig and GatewayConfigs?

Good catch. We should rename it, but now I wonder if having Gateway in the name is confusing since it is referenced in the GatewayClass.

[sjberman]

I wonder if having Gateway in the name is confusing since it is referenced in the GatewayClass.

Even though it's defined on the class, since it's technically set on each Gateway, is it really that confusing?

[kate-osborn]

I wonder if having Gateway in the name is confusing since it is referenced in the GatewayClass.

Even though it's defined on the class, since it's technically set on each Gateway, is it really that confusing?

Perhaps not

[sjberman]

Although I've always thought Config is a redundant term for a CRD, because all CRDs are config. I could see the confusion when saying GatewayConfig vs a Gateway config.

Maybe there's a better name we can come up with here...

[kate-osborn]

Although I've always thought Config is a redundant term for a CRD, because all CRDs are config. I could see the confusion when saying GatewayConfig vs a Gateway config.

Maybe there's a better name we can come up with here...

Since we named the control plane CRD NginxGateway, we could call this NginxProxy or NginxDataplane

[sjberman]

NginxProxy seems good to me. @pleshakov?

It mimics our original data plane CRD name.

[pleshakov]

@sjberman

NginxProxy seems good to me. @pleshakov?

It mimics our original data plane CRD name.

👍

[sjberman]

@kate-osborn @pleshakov If you two wouldn't mind making sure my name change looks good before I merge, that would be much appreciated.

[kate-osborn]

@kate-osborn @pleshakov If you two wouldn't mind making sure my name change looks good before I merge, that would be much appreciated.

LGTM @sjberman