Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ClientSettingsPolicy future work section #1785

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Update the ClientSettingsPolicy future work section to include supporting attaching to GRPCRoutes and adding HTTP/2 and HTTP/3 directives.

Problem: The ClientSettingsPolicy didn't address GRPCRoute attachment or HTTP/2 and HTTP/3 directives.

Solution: Add GRPCRoute attachment and HTTP/2 and HTTP/3 directives to the future work section of the ClientSettingsPolicy.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@kate-osborn kate-osborn requested review from a team as code owners March 27, 2024 18:24
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 27, 2024
@kate-osborn kate-osborn merged commit a58d870 into nginxinc:main Mar 27, 2024
40 checks passed
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this pull request Apr 3, 2024
Update the ClientSettingsPolicy future work section 
to include supporting attaching to GRPCRoutes 
and adding HTTP/2 and HTTP/3 directives.

Problem: The ClientSettingsPolicy didn't address 
GRPCRoute attachment or HTTP/2 and HTTP/3 directives.

Solution: Add GRPCRoute attachment and HTTP/2 and HTTP/3 
directives to the future work section of the ClientSettingsPolicy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants