Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CRDs to config directory #1798

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Apr 2, 2024

Proposed changes

Problem: The CRDs are generated inside the helm chart directory instead of the standard config directory.

Solution: Modify the output parameter of the CRDs generation to save them in the config directory. Also add symlinks to the other locations where we expect to find CRDs.

Closes #1740

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: The CRDs are generated inside the helm chart directory instead
of the standard config directory.

Solution: Modify the output parameter of the CRDs generation to save
them in the config directory. Also add symlinks to the other locations
where we expect to find CRDs.
@lucacome lucacome requested a review from a team as a code owner April 2, 2024 02:31
@github-actions github-actions bot added chore Pull requests for routine tasks helm-chart Relates to helm chart labels Apr 2, 2024
Copy link
Contributor

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any docs changes that are needed? Or no since we have symlinks?

Makefile Show resolved Hide resolved
@lucacome
Copy link
Member Author

lucacome commented Apr 2, 2024

I didn't see anything in the docs that needs to be changed, it should all work the same with the symlink

Makefile Show resolved Hide resolved
@lucacome lucacome merged commit 5ac4c82 into nginxinc:main Apr 3, 2024
40 checks passed
@lucacome lucacome deleted the chore/config-crd branch April 3, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks helm-chart Relates to helm chart
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move crds to config/crd/
4 participants