Run functional and NFR tests with ginkgo #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
lucacome
force-pushed
the
tests/functional-ginkgo
branch
3 times, most recently
from
d6115bf
to
9d31abb
Compare
lucacome
changed the title
sjberman
approved these changes
Apr 19, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Problem: Our tests use ginkgo but we run tests with `go test` Solution: Switch to running test with ginkgo
lucacome
force-pushed
the
tests/functional-ginkgo
branch
from
81c1455
to
28032cf
Compare
ciarams87
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: Our tests use ginkgo but we run tests with
go testSolution: Switch to running test with ginkgo
Closes #1677
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.