Add ObservabilityPolicy CRD #1848
Merged
+817
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-osborn
approved these changes
Apr 18, 2024
pleshakov
reviewed
Apr 18, 2024
github-actions
bot
added
the
documentation
kate-osborn
approved these changes
Apr 19, 2024
pleshakov
reviewed
Apr 19, 2024
Problem: Users want to be able to configure observability settings for their HTTPRoutes, such as tracing. Solution: Add the ObservabilityPolicy CRD, which is a direct policy that will attach to HTTPRoutes to configure these settings. Note: this pR contains the CRD only. A subsequent PR will add the implementation. Also removed some regex restrictions in the NginxProxy CRD.
sjberman
force-pushed
the
enh/observability-policy-crd
branch
from
9c2f8d9
to
62684f3
Compare
pleshakov
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Users want to be able to configure observability settings for their HTTPRoutes, such as tracing.
Solution: Add the ObservabilityPolicy CRD, which is a direct policy that will attach to HTTPRoutes to configure these settings. Note: this pR contains the CRD only. A subsequent PR will add the implementation.
Also removed some regex restrictions in the NginxProxy CRD.
Testing: Verified that the CRD is created and validation works.
Please focus on (optional): We may need to update the regex as we implement and find out that certain values don't work.
Closes #1826
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.