Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added release process to README.md. #191

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Added release process to README.md. #191

merged 2 commits into from
Aug 22, 2022

Conversation

pammecrandall
Copy link
Contributor

@pammecrandall pammecrandall commented Aug 17, 2022 •
edited by f5yacobucci

Proposed changes

Added release process documentation for reference. Intentionally not adding explicit link to README.md, may be added later.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pammecrandall pammecrandall added the documentation Improvements or additions to documentation label Aug 17, 2022
f5yacobucci
f5yacobucci reviewed Aug 17, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@pleshakov
Copy link
Contributor

Hi @pammecrandall
With this commit 7d523ae , the docs now are in a separate folder, rather than in the readme.

Could you put the release process content in a separate file in the docs folder? For example, release-process.md.

@pammecrandall
Copy link
Contributor Author

pammecrandall commented Aug 18, 2022 •
edited

@pleshakov

Could you put the release process content in a separate file in the docs folder? For example, release-process.md.

Sure! That's done now.

@f5yacobucci f5yacobucci enabled auto-merge (squash) August 22, 2022 17:52
@f5yacobucci f5yacobucci merged commit f6976c4 into nginxinc:main Aug 22, 2022
f5yacobucci pushed a commit to f5yacobucci/nginx-kubernetes-gateway that referenced this pull request Aug 22, 2022
@pammecrandall @f5yacobucci
Added release process to README.md. (nginxinc#191)
60d09ee 
Added release procedure documentation: docs/release-process.md.

Co-authored-by: Matthew Yacobucci <m.yacobucci@f5.com>
(cherry picked from commit f6976c4)
f5yacobucci added a commit that referenced this pull request Aug 22, 2022
@f5yacobucci @pammecrandall
Added release process to README.md. (#191) (#207)
d0d604b 
Added release procedure documentation: docs/release-process.md.

Co-authored-by: Matthew Yacobucci <m.yacobucci@f5.com>
(cherry picked from commit f6976c4)

Co-authored-by: Pamme <p.crandall@f5.com>
@pleshakov pleshakov added the skip-changelog Pull requests that don't need to be added to the changelog. label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f5yacobucci f5yacobucci f5yacobucci approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation skip-changelog Pull requests that don't need to be added to the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pammecrandall @pleshakov @f5yacobucci