Design evaluation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5yacobucci
commented
Oct 28, 2021
f5yacobucci
force-pushed
the
design-evaluation
branch
2 times, most recently
from
15d1089
to
710611a
Compare
pleshakov
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
@f5yacobucci looks good!
small note:
note sure if this https://github.com/nginxinc/nginx-gateway-kubernetes/blob/710611a70108f7f1f7875d75b19012b41f3e0dbf/design/gateway-evaluation.md#where-applicable-gateway-evaluation-will-write-status-updates-to-gateway-api-resources-according-to-specification-requirements-each-update-is-not-recorded-in-these-flows and https://github.com/nginxinc/nginx-gateway-kubernetes/blob/710611a70108f7f1f7875d75b19012b41f3e0dbf/design/gateway-evaluation.md#notethis-is-not-a-design-requirement-and-may-not-be-met-as-a-delivery-constraint were supposed to be section headers
tomasohaodha
reviewed
Nov 5, 2021
First draft of NGINX Gateway evaluation engineering document.
- Removed some implementation details around technologies - Moved code layout into Appendix - Added more startup constraints (no traffic passing, init state conflict resolution) - Added Service and Endpoints requirements - Grammar clean up
f5yacobucci
force-pushed
the
design-evaluation
branch
from
710611a
to
add0972
Compare
6 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NGINX Gateway initial evaluation engineering document.