Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing upstream remote command to quickstart guide #2003

Merged
merged 1 commit into from
May 21, 2024

Conversation

sarthyparty
Copy link
Contributor

Proposed changes

Problem: The Quickstart instructions were missing the command to the upstream remote

Solution: I added the missing command to add the upstream remote

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@sarthyparty sarthyparty requested review from a team as code owners May 20, 2024 22:38
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks labels May 20, 2024
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pleshakov
Copy link
Contributor

@sarthyparty
a few style nits related to https://github.com/nginxinc/nginx-gateway-fabric/blob/main/docs/developer/pull-request.md#commit-message-format and commit message

(1) let's expand commit message with problem/solution statements as described in the document above.

(2) better to use active voice in commit messages. For example, Fix git clone command in developer guide. Same for PR name.

@sarthyparty sarthyparty changed the title Quickstart guide was missing upstream remote command Added missing upstream remote command to quickstart guide May 21, 2024
@sarthyparty sarthyparty changed the title Added missing upstream remote command to quickstart guide Add missing upstream remote command to quickstart guide May 21, 2024
Problem: The Quickstart instructions were missing the command
to the upstream remote

Solution: I added the missing command to add the upstream remote
@sarthyparty sarthyparty enabled auto-merge (squash) May 21, 2024 16:53
@sarthyparty sarthyparty merged commit 206f136 into nginxinc:main May 21, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants