Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gateway API CRDs to the repo with kustomize #2011

Merged
merged 2 commits into from
May 28, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented May 22, 2024

Proposed changes

Problem: We don't have a way to tie a version of the Gateway API to our release (or edge). There's also not a single source of truth for the API version.

Solution: Use kustomize to add a specific version of the CRDs to our codebase. This way we only have to manage the version in one place and we can tie it to our releases.

Please focus on (optional): Deploying standard and experimental versions of the API or main for our tests.

Continuation of #1803

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks helm-chart Relates to helm chart labels May 22, 2024
@lucacome lucacome marked this pull request as ready for review May 22, 2024 21:23
@lucacome lucacome requested review from a team as code owners May 22, 2024 21:23
@lucacome lucacome self-assigned this May 23, 2024
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

charts/nginx-gateway-fabric/README.md Outdated Show resolved Hide resolved
docs/developer/release-process.md Show resolved Hide resolved
@lucacome lucacome merged commit f908851 into nginxinc:main May 28, 2024
40 checks passed
@lucacome lucacome deleted the chore/kustomize-gw-api branch May 28, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants