Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFR scale test to GitHub actions pipeline #2024

Merged
merged 2 commits into from
May 23, 2024

Conversation

pleshakov
Copy link
Contributor

Proposed changes

Problem:
Scale test is not part of Github actions pipeline

Solution:

  • Add NFR scale test to GitHub actions pipeline along other NFR tests.
  • Increase the size of the cluster used for NFR tests, as the scale test requires bigger size.

Testing:

Some scale test issues were discovered:

Closes #1927

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem:
Scale test is not part of Github actions pipeline

Solution:
- Add NFR scale test to GitHub actions pipeline along other NFR tests.
- Increase the size of the cluster used for NFR tests, as the scale
  test requires bigger size.

Testing:
- Successfully run with NGINX -- #2002
- Successfully run with NGINX Plus -- #2017

Some scale test issues were discovered:
- #2023
- #2009

Closes #1927
@pleshakov pleshakov requested a review from a team as a code owner May 23, 2024 18:08
@github-actions github-actions bot added the tests Pull requests that update tests label May 23, 2024
@pleshakov pleshakov merged commit 3095a23 into main May 23, 2024
40 checks passed
@lucacome lucacome deleted the test/run-scale-test-in-pipeline branch June 20, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add NFR scale test to GitHub actions pipeline
4 participants