Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chart-testing to lint the Helm Chart #2027

Merged
merged 3 commits into from
May 30, 2024
Merged

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented May 23, 2024

Proposed changes

Problem: We want to validate all the files related to the helm chart and not just run helm lint

Solution: Use helm/chart-testing

Closes #2043

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@github-actions github-actions bot added chore Pull requests for routine tasks helm-chart Relates to helm chart labels May 23, 2024
@lucacome lucacome force-pushed the chore/helm branch 2 times, most recently from c72c3f8 to ef63773 Compare May 23, 2024 22:50
Problem: We want to validate all the files related to the helm chart and not just run helm lint

Solution: Use helm/chart-testing
@lucacome lucacome changed the title test ct Use chart-testing to lint the Helm Chart May 29, 2024
@lucacome lucacome marked this pull request as ready for review May 29, 2024 02:53
@lucacome lucacome requested a review from a team as a code owner May 29, 2024 02:53
@lucacome lucacome self-assigned this May 29, 2024
Copy link
Contributor

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the pipeline, it looks like it ran on version 1.2.0, not latest main? Or is that just printing out the latest tag?

.ct.yaml Show resolved Hide resolved
@sjberman
Copy link
Contributor

This log in the pipeline run: nginx-gateway-fabric => (version: "1.2.0", path: "charts/nginx-gateway-fabric"), doesn't mean it's running on the 1.2.0 tag, does it? It just detects the latest version and prints it I hope?

@lucacome
Copy link
Member Author

yeah it prints the version in Chart.yaml

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (16f0835) to head (d5c91ad).

Current head d5c91ad differs from pull request most recent head 6559f9c

Please upload reports for the commit 6559f9c to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2027   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files          96       96           
  Lines        6694     6694           
  Branches       50       50           
=======================================
  Hits         5865     5865           
  Misses        773      773           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome merged commit 3220d74 into nginxinc:main May 30, 2024
38 checks passed
@lucacome lucacome deleted the chore/helm branch May 30, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks helm-chart Relates to helm chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use chart-testing to lint all the helm related files
4 participants