Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run graceful recovery tests in pipeline #2045

Merged
merged 11 commits into from
Jun 5, 2024

Conversation

salonichf5
Copy link
Contributor

Proposed changes

Problem: As a user, I want to automate graceful recovery tests

Solution: Added a job to run graceful recovery tests in pipeline

Testing: Running it as part of pipeline

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #1910

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@salonichf5 salonichf5 requested a review from a team as a code owner May 29, 2024 00:12
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels May 29, 2024
tests/suite/graceful_recovery_test.go Outdated Show resolved Hide resolved
tests/graceful-recovery/graceful-recovery.md Outdated Show resolved Hide resolved
.github/workflows/functional.yml Outdated Show resolved Hide resolved
@bjee19
Copy link
Contributor

bjee19 commented May 29, 2024

Looking in the pipeline that was run for the functional tests, looks like because of some label the test is getting skipped:

Will run 2 of 17 specs
------------------------------
[BeforeSuite] 
/home/runner/work/nginx-gateway-fabric/nginx-gateway-fabric/tests/suite/system_suite_test.go:248
  [SKIPPED] in [BeforeSuite] - /home/runner/work/nginx-gateway-fabric/nginx-gateway-fabric/tests/suite/system_suite_test.go:130 @ 05/29/24 00:22:[45](https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/9278039607/job/25528584310?pr=2045#step:14:46).584
S [SKIPPED] [0.015 seconds]
[BeforeSuite] 
/home/runner/work/nginx-gateway-fabric/nginx-gateway-fabric/tests/suite/system_suite_test.go:248

  [SKIPPED] NFR tests can only run in GKE
  In [BeforeSuite] at: /home/runner/work/nginx-gateway-fabric/nginx-gateway-fabric/tests/suite/system_suite_test.go:130

@salonichf5 salonichf5 force-pushed the feat/automate-gracefulRecovery branch from 17d1bbe to ad5618d Compare May 29, 2024 20:25
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label May 29, 2024
@salonichf5 salonichf5 force-pushed the feat/automate-gracefulRecovery branch from ad5618d to b59ef51 Compare May 29, 2024 20:26
@salonichf5 salonichf5 force-pushed the feat/automate-gracefulRecovery branch from 6b3d2aa to 15ad48c Compare May 29, 2024 22:02
.github/workflows/functional.yml Outdated Show resolved Hide resolved
tests/suite/system_suite_test.go Outdated Show resolved Hide resolved
@sjberman
Copy link
Contributor

sjberman commented Jun 1, 2024

Be sure to name your branches appropriately so the PR gets tagged the right way. These are test changes, not a feature or enhancement.

@sjberman sjberman added tests Pull requests that update tests and removed enhancement New feature or request labels Jun 1, 2024
@github-actions github-actions bot added enhancement New feature or request and removed tests Pull requests that update tests labels Jun 3, 2024
@bjee19
Copy link
Contributor

bjee19 commented Jun 3, 2024

Why did the bot add the enhancement label and remove the test label 🤔 ? Is it because of the naming of the branch?

@salonichf5 salonichf5 requested a review from sjberman June 3, 2024 18:43
@sjberman
Copy link
Contributor

sjberman commented Jun 3, 2024

@bjee19 Because the branch is named with feat instead of test.

@salonichf5 salonichf5 removed the enhancement New feature or request label Jun 3, 2024
@salonichf5
Copy link
Contributor Author

Be sure to name your branches appropriately so the PR gets tagged the right way. These are test changes, not a feature or enhancement.

I'll ensure to update the tag before merge! @bjee19 @sjberman

@salonichf5 salonichf5 self-assigned this Jun 3, 2024
@salonichf5 salonichf5 requested a review from bjee19 June 3, 2024 21:46
@github-actions github-actions bot added the enhancement New feature or request label Jun 4, 2024
@salonichf5 salonichf5 force-pushed the feat/automate-gracefulRecovery branch from 514cd56 to 19e3c07 Compare June 4, 2024 23:00
@salonichf5 salonichf5 added bug Something isn't working and removed enhancement New feature or request labels Jun 4, 2024
@github-actions github-actions bot added enhancement New feature or request and removed bug Something isn't working labels Jun 5, 2024
@salonichf5 salonichf5 force-pushed the feat/automate-gracefulRecovery branch from 3be07d6 to 7d3badb Compare June 5, 2024 00:28
@salonichf5 salonichf5 force-pushed the feat/automate-gracefulRecovery branch from 7d3badb to 2d4d527 Compare June 5, 2024 04:32
@salonichf5 salonichf5 merged commit 01a18c6 into nginxinc:main Jun 5, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Graceful-Recovery NFR test to pipeline on PRs and merges to main
4 participants