Test Chart installation for Plus and remote images #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
lucacome
force-pushed
the
chore/helm-plus
branch
3 times, most recently
from
b4c462b
to
777dda4
Compare
lucacome
changed the title
lucacome
force-pushed
the
chore/helm-plus
branch
2 times, most recently
from
f008a19
to
fe837f1
Compare
sjberman
reviewed
May 30, 2024
kate-osborn
reviewed
May 31, 2024
Problem: We're not testing the Helm Chart installation with NGINX Plus and with pre-built images Solution: Add installation steps for both
sjberman
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: We're not testing the Helm Chart installation with NGINX Plus
and with pre-built images
Solution: Add installation steps for both
Closes #1967
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.