Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace yq with sed #2062

Merged
merged 2 commits into from
May 30, 2024
Merged

Replace yq with sed #2062

merged 2 commits into from
May 30, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented May 30, 2024

Proposed changes

Problem: yq is not installed by default in all systems

Solution: Replace it with sed, which is more popular

Closes #2061

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: yq is not installed by default in all systems

Solution: Replace it with sed, which is more popular
@lucacome lucacome requested a review from a team as a code owner May 30, 2024 18:37
@github-actions github-actions bot added the chore Pull requests for routine tasks label May 30, 2024
@lucacome lucacome enabled auto-merge (squash) May 30, 2024 19:17
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (cb72c25) to head (ab63f9f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2062      +/-   ##
==========================================
+ Coverage   87.61%   95.00%   +7.38%     
==========================================
  Files          96        1      -95     
  Lines        6694      220    -6474     
  Branches       50       50              
==========================================
- Hits         5865      209    -5656     
+ Misses        773       11     -762     
+ Partials       56        0      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome merged commit d943b50 into nginxinc:main May 30, 2024
40 checks passed
@lucacome lucacome deleted the chore/sed branch May 31, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Gateway API version auto detection doesn't work on GKE VM
3 participants