Fix longevity test runs #2065
Merged
Fix longevity test runs #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also fix line 130 since it likely suffers from the same issue? |
lucacome
reviewed
May 30, 2024
|
@sjberman line 130 works because it's just make and not calling a bash script |
Problem: Running longevity test mistakenly runs all other NFRs make start-longevity-test and make stop-longevity-test mistakenly executes all NFRs. Only longevity test must run. Solution: Problem was introduced in 8671fb7 Ensure the env variables are exported so that they are passed to nfr-test target. Testing: - Ran make start-longevity-test and make stop-longevity-test successfully. CLOSES - nginxinc#2064
pleshakov
force-pushed
the
test/fix-longevity-runs
branch
from
e9fd8e6
to
1786098
Compare
lucacome
approved these changes
May 30, 2024
sjberman
approved these changes
May 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2065 +/- ##
==========================================
+ Coverage 87.61% 95.00% +7.38%
==========================================
Files 96 1 -95
Lines 6694 220 -6474
Branches 50 50
==========================================
- Hits 5865 209 -5656
+ Misses 773 11 -762
+ Partials 56 0 -56 ☔ View full report in Codecov by Sentry. |
lucacome
pushed a commit
to lucacome/nginx-kubernetes-gateway
that referenced
this pull request
May 31, 2024
Problem: Running longevity test mistakenly runs all other NFRs make start-longevity-test and make stop-longevity-test mistakenly executes all NFRs. Only longevity test must run. Solution: Problem was introduced in 18671fb Ensure the env variables are exported so that they are passed to nfr-test target. Testing: - Ran make start-longevity-test and make stop-longevity-test successfully. CLOSES - nginxinc#2064
lucacome
added a commit
to lucacome/nginx-kubernetes-gateway
that referenced
this pull request
May 31, 2024
* Fix longevity test runs (nginxinc#2065) Problem: Running longevity test mistakenly runs all other NFRs make start-longevity-test and make stop-longevity-test mistakenly executes all NFRs. Only longevity test must run. Solution: Problem was introduced in 18671fb Ensure the env variables are exported so that they are passed to nfr-test target. Testing: - Ran make start-longevity-test and make stop-longevity-test successfully. CLOSES - nginxinc#2064 * test notes --------- Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
Running longevity test mistakenly runs all other NFRs make start-longevity-test and make stop-longevity-test mistakenly executes all NFRs. Only longevity test must run.
Solution:
Problem was introduced in 18671fb
Ensure the env variables are exported so that they are passed to nfr-test target.
Testing:
CLOSES - #2064
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.