Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run golang-ci lint for all the modules #2081

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jun 4, 2024

Proposed changes

Problem: golangci-lint is not running for the tests module so we currently have a few errors.

Solution: run golangci-lint for the tests module and fix the errors

Closes #2077

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner June 4, 2024 01:23
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 4, 2024
.golangci.yml Show resolved Hide resolved
Makefile Show resolved Hide resolved
internal/mode/static/handler.go Show resolved Hide resolved
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (fc2ed96) to head (66fad76).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2081   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files          96       96           
  Lines        6694     6694           
  Branches       50       50           
=======================================
  Hits         5865     5865           
  Misses        773      773           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome enabled auto-merge (squash) June 4, 2024 18:26
@lucacome lucacome merged commit 212c0f6 into nginxinc:main Jun 4, 2024
41 checks passed
@lucacome lucacome deleted the chore/golangci-lint branch July 2, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix lint problems in tests
3 participants