Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable more linters #2089

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Enable more linters #2089

wants to merge 5 commits into from

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jun 4, 2024

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels Jun 4, 2024
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Jun 4, 2024
lucacome
lucacome commented Jun 4, 2024
View reviewed changes
internal/mode/static/state/graph/backend_tls_policy_test.go Outdated Show resolved Hide resolved
internal/mode/static/state/graph/backend_tls_policy_test.go
t.Run(test.name, func(t *testing.T) {
// t.Parallel()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails with data race if run in parallel

internal/mode/static/state/graph/configmaps_test.go
t.Run(test.name, func(t *testing.T) {
// t.Parallel()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails with data race if run in parallel

internal/mode/static/state/graph/gateway_test.go
t.Run(test.name, func(t *testing.T) {
// t.Parallel()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails with data race if run in parallel

internal/mode/static/state/graph/backend_refs_test.go
t.Run(test.name, func(t *testing.T) {
// t.Parallel()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails with data race if run in parallel

internal/mode/static/state/graph/graph_test.go
t.Run(test.name, func(t *testing.T) {
// t.Parallel()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails with data race if run in parallel

internal/mode/static/state/graph/route_common_test.go
t.Run(test.name, func(t *testing.T) {
// t.Parallel()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails with data race if run in parallel

internal/mode/static/state/graph/secret_test.go
@@ -67,6 +67,7 @@ cpLlHMAqbLJ8WYGJCkhiWxyal6hYTyWY4cVkC0xtTl/hUE9IeNKo
)

func TestSecretResolver(t *testing.T) {
// t.Parallel()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails with data race if run in parallel

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this one fails since it's just one test...

internal/mode/static/state/store_test.go Show resolved Hide resolved
internal/mode/static/state/store_test.go
t.Run(test.name, func(t *testing.T) {
// t.Parallel()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails with data race if run in parallel

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Jun 22, 2024
@github-actions github-actions bot removed the stale Pull requests/issues with no activity label Jun 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Jul 12, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (3c029b1) to head (bbb80a2).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2089   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files         100      100           
  Lines        7512     7512           
  Branches       50       50           
=======================================
  Hits         6678     6678           
  Misses        778      778           
  Partials       56       56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the stale Pull requests/issues with no activity label Jul 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added stale Pull requests/issues with no activity and removed stale Pull requests/issues with no activity labels Jul 27, 2024
@lucacome lucacome force-pushed the chore/linters branch 2 times, most recently from e7b70b9 to 06f461f Compare August 8, 2024 22:34
@lucacome lucacome mentioned this pull request Aug 9, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
NGINX Gateway Fabric
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lucacome