Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific instruction for upgrading NGF from OSS to Plus #2104

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

ciarams87
Copy link
Member

Proposed changes

Problem: There is a doc that covers pulling the N+ image, however there is no clear explanation for supported customers at how they would go through the process of moving from the free implementation to the paid implementation (replacing NGINX OSS with NGINX Plus).

Solution: Add sections to the installation docs that covers this use-case

Testing: Ran through the steps locally

Please focus on (optional): This could be a separate doc, but I'm not sure of its value. Upgrading from OSS to Plus is very straight-forward

Closes #1933

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@ciarams87 ciarams87 requested review from a team as code owners June 6, 2024 12:01
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 6, 2024
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides one small suggestion.

site/content/installation/installing-ngf/manifests.md Outdated Show resolved Hide resolved
@ciarams87 ciarams87 enabled auto-merge (squash) June 7, 2024 10:10
@ciarams87 ciarams87 merged commit 7c9bf23 into nginxinc:main Jun 7, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

How to upgrade from OSS NGINX to NGINX+ in NGF
4 participants