Test/add runtime manager tests

[miledxz]

Proposed changes

Reopening pr trough another pr because issues on github

update on this: #1555, since I did mistake and discarded all commits,
I haven't find better solution so I opened another pr @sjberman @kate-osborn

• [ x] I have read the CONTRIBUTING doc
• [ x] I have added tests that prove my fix is effective or that my feature works
• [ x] I have checked that all unit tests pass after adding my changes
• [ x] I have updated necessary documentation
• [ x] I have rebased my branch onto main
• [ x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

[github-actions]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[miledxz]

I just added another commit update here:
fe8d2fc

according to these:
#2175 (comment)
#2175 (comment)

#1555 (comment)
#1555 (comment)

gentle ping for @kate-osborn , I can add more updates if required

[codecov]

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.

Project coverage is 89.26%. Comparing base (9a2c91b) to head (eda39b2).

Files	Patch %	Lines
internal/mode/static/manager.go	0.00%	4 Missing ⚠️
internal/mode/static/nginx/runtime/manager.go	75.00%	4 Missing ⚠️
internal/mode/static/nginx/runtime/verify.go	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2175      +/-   ##
==========================================
+ Coverage   88.84%   89.26%   +0.42%     
==========================================
  Files         100      100              
  Lines        7527     7535       +8     
  Branches       50       50              
==========================================
+ Hits         6687     6726      +39     
+ Misses        784      752      -32     
- Partials       56       57       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[miledxz]

latest updates are in this commit: 8b94a05

[kate-osborn]

@miledxz can you change this type to nginxPlusClient interface defined in the nginx runtime package?

The functional tests fail because the function IsPlus on the nginx runtime manager returns true even when the nginxPlusClient is nil. This is due to a subtlety around interface types.

If you pass a nil *ngxclient.NginxClient as the type nginxPlusClient, it will not evaluate as nil. Take a look at this go playground example: https://goplay.tools/snippet/sDiRga5qSqm

We need to change this type to the interface nginxPlusClient type to fix this. This means you will need to export the nginxPlusClient interface and modify the collectors.NewNginxPlusMetricsCollector function to accept the interface instead of the actual client.

Apologies for not catching this sooner.

[kate-osborn]

@miledxz there's a couple errors in the pipeline that need to be fixed:

cannot find package with target: nginxPlusClient
Writing `FakeNginxPlusClient` to `runtimefakes/fake_nginx_plus_client.go`... exit status 1

  Error: internal/mode/static/metrics/collectors/nginx.go:33:3: cannot use plusClient (variable of type "github.com/nginxinc/nginx-gateway-fabric/internal/mode/static/nginx/runtime".NginxPlusClient) as *"github.com/nginxinc/nginx-plus-go-client/client".NginxClient value in argument to nginxCollector.NewNginxPlusCollector: need type assertion (typecheck)