Implement request redirect filter in HTTPRoute rule #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
commented
Aug 31, 2022
kate-osborn
requested changes
Sep 6, 2022
This commit implements the request redirect filter as part of the routing rule in the HTTPRoute. A common use-case for a request redirect is redirecting HTTP requests to HTTPS. The commit updates the HTTPS termination example to include HTTPS redirect configuration. Notes: - The experimental 'path' field of 'requestRedirect' is out of scope. - The validation of the fields of `requestRedirect` is not implemented. It is left to be done in a separate component responsible for validation with FIXMEs added to the relevant code locations. - If multiple redirect filters are configured, NGINX Kubernetes Gateway will choose the first one and ignore the rest. - NGINX will always redirect a request even if the request has already been redirected. Thus, any backendRefs defined in the routing rule will be ignored. However, that "always redirect" behavior is not specified by the Gateway API. As a result, we might need to change our implementation if different behavior becomes specified by the Gateway API in the future.
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
pleshakov
force-pushed
the
feature/redirect
branch
from
221d87f
to
875b213
Compare
kate-osborn
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR implements the request redirect filter as part of the routing
rule in the HTTPRoute.
A common use-case for a request redirect is redirecting HTTP requests
to HTTPS. The PR updates the HTTPS termination example to include
HTTPS redirect configuration.
Notes:
requestRedirectis not implemented.It is left to be done in a separate component responsible for validation
with FIXMEs added to the relevant code locations.
will choose the first one and ignore the rest.
been redirected. Thus, any backendRefs defined in the routing rule will
be ignored. However, that "always redirect" behavior is not specified
by the Gateway API. As a result, we might need to change our
implementation if different behavior becomes specified by the Gateway API
in the future.