Fix status for parentRef with invalid listener in HTTPRoute #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
reviewed
Jan 6, 2023
kate-osborn
force-pushed
the
fix/invalid-listener-route-status
branch
from
cd15f90
to
ff89684
Compare
pleshakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: If an HTTPRoute references an invalid listener in a parentRef, the status is incorrectly reported as
Accepted:TrueFix: Check if the listener associated with the parentRef is valid when binding HTTPRoutes to listeners. If not valid, mark the section name as invalid with a condition of
Accepted:Falseand a Reason ofInvalidListenerNote: The spec does not define a Reason that covers this case where the listener is invalid. This PR adds a new route Reason
InvalidListenerfor this case. There's an open discussion about adding this Reason to the spec: kubernetes-sigs/gateway-api#1445