Fix whitespace in nginx templates

[sjberman]

The nginx templates were hard to read due to excessive whitespacing in the templates. It's not perfect, but these changes should clean things up quite a bit.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

[pleshakov]

The generated config is much easier to read now:

upstream default_coffee_80 {
    random two least_conn;

    server 10.244.0.9:8080;
}

upstream default_tea_80 {
    random two least_conn;

    server 10.244.0.10:8080;
}

upstream invalid-backend-ref {
    random two least_conn;

    server unix:/var/lib/nginx/nginx-500-server.sock;
}





server {
        listen 80 default_server;

        default_type text/html;
        return 404;
}

server {

        server_name cafe.example.com;


        location /coffee {
                proxy_set_header Host $host;
                proxy_pass http://default_coffee_80$request_uri;
        }

        location /tea {
                proxy_set_header Host $host;
                proxy_pass http://default_tea_80$request_uri;
        }

        location / {
                return 404 "";

        }

}

server {
    listen unix:/var/lib/nginx/nginx-502-server.sock;
    access_log off;

    return 502;
}

server {
    listen unix:/var/lib/nginx/nginx-500-server.sock;
    access_log off;

    return 500;

My only concern is figuring out how to use those whitespace reduction techniques going forward (confession - I haven't mastered them :) ) Is there a set of rules/ guidelines we can have for our template writing? So that any developer can follow them, and any reviewer of future template changes can also follow them, and they both can arrive at similar result?

I think another approach is just eliminate all empty lines. For example, during template generatation.

[sjberman]

@pleshakov It's definitely a bit finicky to get all the spacing correct, especially when trying to balance readability in the code using empty lines with readability in the rendered template. There may not be a perfect solution.

Regarding the templating, this is how it works.

[pleshakov]

👍