Chore: create pipeline #6
Merged
+360
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5yacobucci
reviewed
Nov 12, 2021
f5yacobucci
reviewed
Nov 12, 2021
pleshakov
approved these changes
Nov 12, 2021
ciarams87
force-pushed
the
chore/create-pipeline
branch
3 times, most recently
from
fce5f02
to
b760c7e
Compare
|
Lint and unit-tests are failing with "undeclared name: |
|
@ciarams87 this is probably because that missing type is defined here https://github.com/nginxinc/nginx-gateway-kubernetes/blob/b760c7e749b0001d54a8676b1a853e25ad9ce991/pkg/client/clientset/versioned/typed/v1alpha1/_client.go , which starts with I will prepare a fix update: @f5yacobucci is working on the fix |
ciarams87
force-pushed
the
chore/create-pipeline
branch
from
b760c7e
to
4a2228b
Compare
ciarams87
force-pushed
the
chore/create-pipeline
branch
from
4a2228b
to
206bbbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates the initial pipeline to enable linting, unit testing (although there are no tests yet), codeQL, fossa (including adding the badge to the README), dependabot, and trivy security scanning.
It also adds new linting and formatting make targets, and fixes some linting errors that showed up once the tool was ran.
Happy to add/ remove/ amend as needed!