New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIXME Review #666

Merged

kate-osborn merged 1 commit into nginxinc:main from kate-osborn:chore/update-fixmes

May 23, 2023

Contributor

kate-osborn commented May 23, 2023

Reviewed FIXMEs with team and updated comments.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have checked that all unit tests pass after adding my changes
I have updated necessary documentation
I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork


          FIXME Review

6fec505

Reviewed FIXMEs with team and updated comments.

kate-osborn requested a review from a team as a code owner

May 23, 2023 15:34

github-actions bot added the chore label

pleshakov approved these changes

View reviewed changes

kate-osborn merged commit 3d6b009 into nginxinc:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment