Update route condition where listener is not found #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
sjberman
approved these changes
May 24, 2023
ciarams87
force-pushed
the
feat/update-route-conditions
branch
from
f21e73e
to
4e6927a
Compare
kate-osborn
approved these changes
May 25, 2023
ciarams87
force-pushed
the
feat/update-route-conditions
branch
from
4e6927a
to
8b900ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Report Accepted(false), Reason NoMatchingParent, in the status of HTTPRoute when the section name (listener) in the Gateway is not found.
Closes #306
Checklist
Before creating a PR, run through this checklist and mark each as complete.