Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve provisioner docs #741

Merged
merged 5 commits into from
Jun 13, 2023

Conversation

pleshakov
Copy link
Contributor

Proposed changes

Problem:
It is not obvious that it is necessary to re-build the NKG image to customize the static mode Deployment, which the provisioner uses.

Solution:
Make the docs clearer.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Problem:
It is not obvious that it is necessary to re-build the NKG image to
customize the static mode Deployment, which the provisioner uses.

Solution:
Make the docs clearer.
@pleshakov pleshakov requested a review from a team as a code owner June 9, 2023 23:50
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 9, 2023
Co-authored-by: Saylor Berman <s.berman@f5.com>
pleshakov and others added 2 commits June 12, 2023 11:54
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
@pleshakov pleshakov merged commit 628bd22 into nginxinc:main Jun 13, 2023
14 checks passed
@pleshakov pleshakov deleted the docs/improve-provisioner-doc branch June 13, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants