Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements for Docker image in examples #756

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

pleshakov
Copy link
Contributor

Proposed changes

Problems:

  • For security, we want to use Docker images we can trust -- either managed by NGINX or F5 or an official Docker images.
  • We want contributors to be aware of that requirement.

Solution:

  • Add requirements to the developer docs.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Problems:
- For security, we want to use Docker images we can trust -- either
managed by NGINX or F5 or an official Docker images.
- We want contributors to be aware of that requirement.

Solution:
- Add requirements to the developer docs.
@pleshakov pleshakov requested a review from a team as a code owner June 15, 2023 16:53
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 15, 2023
@pleshakov pleshakov merged commit f64d045 into nginxinc:main Jun 16, 2023
15 checks passed
@pleshakov pleshakov deleted the docs/clarify-example-docker-images branch June 16, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants