Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run conformance tests in the CI pipeline #792

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Run conformance tests in the CI pipeline #792

merged 3 commits into from
Jun 30, 2023

Conversation

ciarams87
Copy link
Member

@ciarams87 ciarams87 commented Jun 27, 2023 •
edited

Proposed changes

Run conformance tests as part of the standard CI pipeline run.

Out of scope: Fixing the currently failing tests

Closes #644

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • [] I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • [] I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 27, 2023
sjberman
sjberman reviewed Jun 27, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@ciarams87 ciarams87 force-pushed the feat/run-conformance-test-pipeline branch 3 times, most recently from bae6a3d to 73707eb Compare June 28, 2023 09:13
@ciarams87 ciarams87 marked this pull request as ready for review June 28, 2023 09:33
@ciarams87 ciarams87 requested a review from a team as a code owner June 28, 2023 09:33
pleshakov
pleshakov reviewed Jun 28, 2023
View reviewed changes
conformance/README.md Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
sjberman
sjberman reviewed Jun 28, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@ciarams87 ciarams87 force-pushed the feat/run-conformance-test-pipeline branch 3 times, most recently from 092858b to 3606730 Compare June 29, 2023 12:33
@ciarams87 ciarams87 force-pushed the feat/run-conformance-test-pipeline branch from 3606730 to 5156aba Compare June 29, 2023 13:40
@ciarams87 ciarams87 requested a review from sjberman June 29, 2023 18:10
@ciarams87 ciarams87 force-pushed the feat/run-conformance-test-pipeline branch from 99250ca to 7ed62c9 Compare June 30, 2023 09:25
@ciarams87 ciarams87 merged commit 104d511 into nginxinc:main Jun 30, 2023
16 checks passed
@ciarams87 ciarams87 deleted the feat/run-conformance-test-pipeline branch June 30, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@sjberman sjberman sjberman approved these changes

@lucacome lucacome Awaiting requested review from lucacome

@kate-osborn kate-osborn Awaiting requested review from kate-osborn

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automated conformance tests in pipeline
3 participants
@ciarams87 @pleshakov @sjberman