Check for changes in generated files in GitHub workflow #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-osborn
force-pushed
the
chore/generatE
branch
2 times, most recently
from
297a04a
to
aff3b50
Compare
kate-osborn
changed the title
lucacome
approved these changes
Jul 11, 2023
ciarams87
approved these changes
Jul 11, 2023
kate-osborn
force-pushed
the
chore/generatE
branch
from
aff3b50
to
aae6377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: If we forget to run
make generate, the out-of-date code can be committed to the main branch. See an example of a problem here.Solution: Add a step to the Checks and variables job in the ci workflow that checks if the generated files have changed. If they have changed, the job will fail, and the PR will be blocked.
Testing: Verified that the job works as expected.