Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update developer docs #851

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Update developer docs #851

merged 1 commit into from
Jul 12, 2023
+25 −1

Conversation

kate-osborn
Copy link
Contributor

Problems:

  • Go style guide is missing guideline on inline error checking
  • Pull request guide is missing guideline on PR titles

Solution: Add guidelines to relevant docs

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@kate-osborn
Update developer docs
60577fa 
Problems:
- Go style guide is missing guideline on inline error checking
- Pull request guide is missing guideline on PR titles

Solution: Add guidelines to relevant docs
@kate-osborn kate-osborn requested a review from a team as a code owner July 12, 2023 18:17
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 12, 2023
pleshakov
pleshakov approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kate-osborn kate-osborn merged commit 1f252c3 into nginxinc:main Jul 12, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@sjberman sjberman sjberman approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kate-osborn @pleshakov @sjberman