Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the release process doc for conformance tests #852

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Update the release process doc for conformance tests #852

merged 1 commit into from
Jul 12, 2023

Conversation

ciarams87
Copy link
Member

@ciarams87 ciarams87 commented Jul 12, 2023 •
edited

Proposed changes

Update the release process doc to reflect that the provisioner manifest and the conformance test Makefile also need to be updated with the correct tag.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner July 12, 2023 19:41
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Jul 12, 2023
kate-osborn
kate-osborn approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ciarams87 ciarams87 merged commit 9316a62 into nginxinc:main Jul 12, 2023
16 checks passed
@ciarams87 ciarams87 deleted the chore/update-release-docs branch July 12, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ciarams87 @sjberman @kate-osborn