Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs to make copying commands easier #859

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

sjberman
Copy link
Contributor

Problem: Commands and their output were saved in the same block, making it difficult for users to simply copy the commands.

Solution: Separate commands and their output into separate blocks in the documentation.

Closes #543

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Problem: Commands and their output were saved in the same block, making it difficult for users to simply copy the commands.

Solution: Separate commands and their output into separate blocks in the documentation.
@sjberman sjberman requested a review from a team as a code owner July 13, 2023 18:56
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 13, 2023
@sjberman
Copy link
Contributor Author

Wasn't totally sure the best way visually to format the command followed by the output, so took a stab at it. Open to feedback.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I added a few suggestions but GitHub keeps lagging so didn't add it in all places 😞

There's a list of supported languages here in case you didn't know https://github.com/github-linguist/linguist/blob/master/lib/linguist/languages.yml

conformance/README.md Show resolved Hide resolved
conformance/provisioner/README.md Outdated Show resolved Hide resolved
docs/building-the-image.md Outdated Show resolved Hide resolved
docs/developer/quickstart.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
examples/advanced-routing/README.md Show resolved Hide resolved
@sjberman sjberman force-pushed the docs/improve-cli-instructions branch from 18b56b9 to 05b03aa Compare July 13, 2023 21:50
@sjberman sjberman force-pushed the docs/improve-cli-instructions branch from 05b03aa to e8b4983 Compare July 13, 2023 21:51
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@sjberman sjberman enabled auto-merge (squash) July 17, 2023 14:35
@sjberman sjberman merged commit e78dea3 into nginxinc:main Jul 17, 2023
15 checks passed
@sjberman sjberman deleted the docs/improve-cli-instructions branch July 18, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Docs: Improve cli instructions
4 participants