Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NJS path in lint workflow #867

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Fix NJS path in lint workflow #867

merged 2 commits into from
Jul 17, 2023

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jul 15, 2023 •
edited

Proposed changes

The path changed after a refactor, this updates it in the workflow too

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome
Fix NJS path in lint workflow
aa4746d 
The path changed after a refactor, this updates it in the workflow too
@lucacome lucacome requested a review from a team as a code owner July 15, 2023 01:41
@lucacome lucacome self-assigned this Jul 15, 2023
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 15, 2023
@lucacome lucacome merged commit acb377a into nginxinc:main Jul 17, 2023
17 checks passed
@lucacome lucacome deleted the chore/fix-njs-path branch July 17, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucacome @sjberman @kate-osborn