Add debug makefile targets #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjberman
approved these changes
Jul 20, 2023
pleshakov
reviewed
Jul 20, 2023
kate-osborn
force-pushed
the
add-debug-target
branch
from
057074c
to
1f8974d
Compare
pleshakov
approved these changes
Jul 21, 2023
ciarams87
approved these changes
Jul 24, 2023
kate-osborn
force-pushed
the
add-debug-target
branch
from
1f8974d
to
bdbc2cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In order to debug NKG while it is running in Kubernetes, you need to build the NKG container with a binary that includes the debug info and symbols and disables optimizations that make debugging hard.
Problem: There are no makefile targets for building a debug binary.
Solution: Add makefile targets for building a debug binary and a container with the debug binary.
Testing: Verified that the debug info and symbols are present and debugging with dlv works.
Checklist
Before creating a PR, run through this checklist and mark each as complete.