Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read dependency config from central repo #907

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jul 25, 2023

Proposed changes

Problem: The config for dependencies needs to be kept up to date

Solution: Rather than having the config for every repo, we can use a central location for all.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

The config was moved to a central repo so it can be used by all k8s
repos without duplicating it.
@lucacome lucacome self-assigned this Jul 25, 2023
@lucacome lucacome requested a review from a team as a code owner July 25, 2023 01:38
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 25, 2023
@lucacome lucacome enabled auto-merge (squash) July 25, 2023 23:12
@lucacome lucacome merged commit bec6d62 into nginxinc:main Jul 25, 2023
19 checks passed
@lucacome lucacome deleted the chore/central-repo branch January 16, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants