Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Proposal (Provisional): Control Plane Dynamic Config #927

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented Aug 2, 2023

New proposal document for dynamically configuration NKG control plane.

Issue: #928

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

New proposal document for dynamically configuration NKG control plane.
@sjberman sjberman requested a review from a team as a code owner August 2, 2023 18:12
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 2, 2023
@sjberman
Copy link
Contributor Author

sjberman commented Aug 2, 2023

Used #554 as the linked issue since that's what started the proposal, though if we'd prefer I could create a more generic issue.

@pleshakov
Copy link
Contributor

Used #554 as the linked issue since that's what started the proposal, though if we'd prefer I could create a more generic issue.

A generic issue makes more sense to me. This will follow our guidelines https://github.com/nginxinc/nginx-kubernetes-gateway/tree/main/docs/proposals Also the issue can include a link to #855 , which is currently lost

@sjberman sjberman changed the title Enhancement Proposal: Control Plane Dynamic Config Enhancement Proposal (Provisional): Control Plane Dynamic Config Aug 2, 2023
@sjberman sjberman merged commit 1d615c4 into nginxinc:main Aug 2, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants