Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Proposal (Implementable): NKG config #930

Merged
merged 5 commits into from
Aug 7, 2023

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented Aug 2, 2023

Update enhancement proposal with implementable details for NKG control plane dynamic configuration.

Issue: #928

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman sjberman requested a review from a team as a code owner August 2, 2023 20:31
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 2, 2023
docs/proposals/control-plane-config.md Show resolved Hide resolved
docs/proposals/control-plane-config.md Outdated Show resolved Hide resolved
docs/proposals/control-plane-config.md Outdated Show resolved Hide resolved
docs/proposals/control-plane-config.md Show resolved Hide resolved
docs/proposals/control-plane-config.md Outdated Show resolved Hide resolved
docs/proposals/control-plane-config.md Outdated Show resolved Hide resolved
docs/proposals/control-plane-config.md Show resolved Hide resolved
docs/proposals/control-plane-config.md Outdated Show resolved Hide resolved
docs/proposals/control-plane-config.md Outdated Show resolved Hide resolved
docs/proposals/control-plane-config.md Show resolved Hide resolved
docs/proposals/control-plane-config.md Show resolved Hide resolved
docs/proposals/control-plane-config.md Show resolved Hide resolved
Update enhancement proposal with implementable details for NKG control plane dynamic configuration.
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sjberman sjberman enabled auto-merge (squash) August 7, 2023 18:07
@sjberman sjberman merged commit d57c399 into nginxinc:main Aug 7, 2023
21 checks passed
@sjberman sjberman deleted the docs/cp-config-proposal branch August 7, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants