Dynamic control plane configuration support #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
sjberman
force-pushed
the
feature/cp-log-level
branch
3 times, most recently
from
36d4930
to
606489f
Compare
pleshakov
suggested changes
Aug 9, 2023
pleshakov
reviewed
Aug 10, 2023
kate-osborn
requested changes
Aug 10, 2023
sjberman
force-pushed
the
feature/cp-log-level
branch
from
606489f
to
ea27fe3
Compare
kate-osborn
approved these changes
Aug 10, 2023
pleshakov
reviewed
Aug 11, 2023
Problem: We want to be able to change control plane settings dynamically, to avoid having to restart NKG and lose valuable state. Solution: Introducing a new CRD that is initialized and created on startup, NginxGateway. This CRD can be updated by the user to dynamically change the state of the control plane. Right now we simply support changing the logging level. The controller will revert to using default values if the CRD is not detected.
sjberman
force-pushed
the
feature/cp-log-level
branch
from
3a879ef
to
7bfa9d5
Compare
sjberman
force-pushed
the
feature/cp-log-level
branch
from
7bfa9d5
to
d945668
Compare
pleshakov
reviewed
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: We want to be able to change control plane settings dynamically, to avoid having to restart NKG and lose valuable state.
Solution: Introducing a new CRD that is initialized and created on startup, NginxGateway. This CRD can be updated by the user to dynamically change the state of the control plane. Right now we simply support changing the logging level. The controller will revert to using default values if the CRD is not detected.
Testing: Manually verified that the log level changes properly when updated. Events/statuses are also properly created when required.
Closes #554 #928