Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builder docker image #988

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Conversation

sjberman
Copy link
Contributor

Problem: The builder docker image was out of date and didn't copy the correct files.
Solution: Copy the whole directory and run the make command to ensure everything is always in sync.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman sjberman requested a review from a team as a code owner August 17, 2023 17:25
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 17, 2023
build/Dockerfile Outdated Show resolved Hide resolved
build/Dockerfile Outdated Show resolved Hide resolved
Problem: The builder docker image was out of date and didn't copy the correct files.
Solution: Copy the whole directory and run the make command to ensure everything is always in sync.
@sjberman sjberman merged commit 8536cde into nginxinc:main Aug 17, 2023
22 checks passed
@sjberman sjberman deleted the chore/fix-builder-image branch August 17, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants