Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update helm schema and docs #210

Merged
merged 7 commits into from
Dec 14, 2023
Merged

Update helm schema and docs #210

merged 7 commits into from
Dec 14, 2023

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Dec 7, 2023 •
edited

Proposed changes

  • Update helm parameter docs missed by the release bot. (up to helm chart version 1.0.2 only)
  • Update readme and sample due to change in ingressClass field, which now takes an object instead of a string.
  • Update generated bundle
  • Remove sample from config/manifests/bases/nginx-ingress-operator.clusterserviceversion.yaml as it is replaced by config/samples/charts_v1alpha1_nginxingress.yaml during make bundle
  • Fix deadlinks in readme

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@haywoodsh haywoodsh requested a review from a team as a code owner December 7, 2023 10:14
@github-actions github-actions bot added the bug An issue reporting a potential bug label Dec 7, 2023
@haywoodsh haywoodsh marked this pull request as draft December 7, 2023 10:15
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Dec 7, 2023
@haywoodsh haywoodsh changed the title Update deployment sample due to schema changes Update changed missed by automated release bot Dec 7, 2023
@haywoodsh haywoodsh linked an issue Dec 7, 2023 that may be closed by this pull request
Fixed Error deploying the default config in openshift: failed to install release: values don't meet the specifications of the schema(s) in the following chart(s): nginx-ingress: - controller.ingressClass: Invalid type. Expected: object, given: string #200
Closed
@haywoodsh haywoodsh marked this pull request as ready for review December 8, 2023 15:45
@jjngx jjngx requested a review from a team December 8, 2023 17:01
@haywoodsh haywoodsh changed the title Update changed missed by automated release bot Update changes missed by automated release bot Dec 8, 2023
@haywoodsh haywoodsh changed the title Update changes missed by automated release bot Update changes missed by bot Dec 8, 2023
@haywoodsh haywoodsh changed the title Update changes missed by bot Update helm schema changes Dec 8, 2023
@haywoodsh haywoodsh changed the title Update helm schema changes Update helm schema changes in sample and docs Dec 8, 2023
@haywoodsh haywoodsh requested a review from a team December 14, 2023 14:42
@haywoodsh haywoodsh changed the title Update helm schema changes in sample and docs Update helm schema and docs Dec 14, 2023
@haywoodsh haywoodsh merged commit fcd095c into main Dec 14, 2023
5 checks passed
@haywoodsh haywoodsh deleted the fix/update-sample branch December 14, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@jjngx jjngx jjngx approved these changes

@pdabelf5 pdabelf5 Awaiting requested review from pdabelf5

Assignees
No one assigned
Labels
bug An issue reporting a potential bug documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
3 participants
@haywoodsh @vepatel @jjngx