Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove leading v from operator PR #221

Merged
merged 1 commit into from
Dec 21, 2023
Merged

remove leading v from operator PR #221

merged 1 commit into from
Dec 21, 2023

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 20, 2023

Proposed changes

operator version was being incorrectly supplied as vv2.1.0

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner December 20, 2023 15:29
@lucacome
Copy link
Member

version: ${{ steps.vars.outputs.version }}

This was set to the wrong variable, you can just change this to steps.meta.outputs.version and everything works

@pdabelf5 pdabelf5 merged commit 1aef758 into main Dec 21, 2023
5 checks passed
@pdabelf5 pdabelf5 deleted the operator-pr-version branch December 21, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants